Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720815 > unrolled thread
| Started by | Priit Laes <plaes@plaes.org> |
|---|---|
| First post | 2017-08-27 15:00 +0200 |
| Last post | 2017-08-31 16:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Priit Laes <plaes@plaes.org> - 2017-08-27 15:00 +0200
Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-28 08:50 +0200
Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Linus Walleij <linus.walleij@linaro.org> - 2017-08-31 16:00 +0200
| From | Priit Laes <plaes@plaes.org> |
|---|---|
| Date | 2017-08-27 15:00 +0200 |
| Subject | [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" |
| Message-ID | <uj5ku-7MW-11@gated-at.bofh.it> |
This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669. The original patch was intented to avoid some issues with the sunxi gpio rework and was supposed to be reverted after all the required DT bits had been merged around v4.10. Signed-off-by: Priit Laes <plaes@plaes.org> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index 0dfd7fa66c48..52edf3b5988d 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c @@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev, val = arg / 10 - 1; break; case PIN_CONFIG_BIAS_DISABLE: - continue; + val = 0; + break; case PIN_CONFIG_BIAS_PULL_UP: if (arg == 0) return -EINVAL; -- 2.13.5
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-08-28 08:50 +0200 |
| Subject | Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" |
| Message-ID | <ujm1Y-2ab-5@gated-at.bofh.it> |
| In reply to | #1720815 |
[Multipart message — attachments visible in raw view] — view raw
1;4803;0c On Sun, Aug 27, 2017 at 03:55:23PM +0300, Priit Laes wrote: > This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669. > > The original patch was intented to avoid some issues with the sunxi > gpio rework and was supposed to be reverted after all the required > DT bits had been merged around v4.10. > > Signed-off-by: Priit Laes <plaes@plaes.org> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-08-31 16:00 +0200 |
| Message-ID | <ukyaK-6kL-37@gated-at.bofh.it> |
| In reply to | #1720815 |
On Sun, Aug 27, 2017 at 2:55 PM, Priit Laes <plaes@plaes.org> wrote: > This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669. > > The original patch was intented to avoid some issues with the sunxi > gpio rework and was supposed to be reverted after all the required > DT bits had been merged around v4.10. > > Signed-off-by: Priit Laes <plaes@plaes.org> Patch applied with Maxime's ACK. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web