Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720815

[PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"

From Priit Laes <plaes@plaes.org>
Newsgroups linux.kernel
Subject [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)"
Date 2017-08-27 15:00 +0200
Message-ID <uj5ku-7MW-11@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


This reverts commit 2154d94b40ea2a5de05245521371d0461bb0d669.

The original patch was intented to avoid some issues with the sunxi
gpio rework and was supposed to be reverted after all the required
DT bits had been merged around v4.10.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 0dfd7fa66c48..52edf3b5988d 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -564,7 +564,8 @@ static int sunxi_pconf_group_set(struct pinctrl_dev *pctldev,
 			val = arg / 10 - 1;
 			break;
 		case PIN_CONFIG_BIAS_DISABLE:
-			continue;
+			val = 0;
+			break;
 		case PIN_CONFIG_BIAS_PULL_UP:
 			if (arg == 0)
 				return -EINVAL;
-- 
2.13.5

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Priit Laes <plaes@plaes.org> - 2017-08-27 15:00 +0200
  Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for  now)" Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-28 08:50 +0200
  Re: [PATCH] Revert "pinctrl: sunxi: Don't enforce bias disable (for now)" Linus Walleij <linus.walleij@linaro.org> - 2017-08-31 16:00 +0200

csiph-web