Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722311 > unrolled thread

Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 12:30 +0200
    Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Neil Horman <nhorman@tuxdriver.com> - 2017-08-29 13:40 +0200
      Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 13:50 +0200
        RE: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Dan Priamo <danp@adiengineering.com> - 2017-08-29 20:20 +0200
          Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 22:10 +0200
            RE: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Dan Priamo <danp@adiengineering.com> - 2017-08-29 22:20 +0200

#1722311 — Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads

[Multipart message — attachments visible in raw view] — view raw

> >> So basically the byte count already precedes the data in the dma_buffer,
> >> then the driver sticks desc->rxbytes in front of this resulting in the
> >> trace above.
> >>
> >> The first patch tackles this.
> >>
> >> The second patch in the series adds a sanity check on the byte count
> >> supplied by the slave device.  This might be a nice to have, but is
> >> probably less critical.
> > 
> > Both patches look good to me. Seth, Neil, do you agree?
> > 
> 
> Ping.
> 
> Not sure what the usual review time is, let me know if this is premature.

I applied both patches to for-next (v4.14) now to get a broader
audience. for-current (v4.13) might have been also applicable, but I
don't want to apply the patches there without the driver maintainer
acks. I hope this works for you.

[toc] | [next] | [standalone]

#1722390

On Tue, Aug 29, 2017 at 12:22:25PM +0200, Wolfram Sang wrote:
> 
> > >> So basically the byte count already precedes the data in the dma_buffer,
> > >> then the driver sticks desc->rxbytes in front of this resulting in the
> > >> trace above.
> > >>
> > >> The first patch tackles this.
> > >>
> > >> The second patch in the series adds a sanity check on the byte count
> > >> supplied by the slave device.  This might be a nice to have, but is
> > >> probably less critical.
> > > 
> > > Both patches look good to me. Seth, Neil, do you agree?
> > > 
> > 
> > Ping.
> > 
> > Not sure what the usual review time is, let me know if this is premature.
> 
> I applied both patches to for-next (v4.14) now to get a broader
> audience. for-current (v4.13) might have been also applicable, but I
> don't want to apply the patches there without the driver maintainer
> acks. I hope this works for you.
> 

Sorry, I've been on vacation, yes, the patches look good to me

Acked-by: Neil Horman <nhorman@tuxdriver.com>

[toc] | [prev] | [next] | [standalone]

#1722399

[Multipart message — attachments visible in raw view] — view raw

> Sorry, I've been on vacation, yes, the patches look good to me

All fine, I was just being cautious.

> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Thanks!

[toc] | [prev] | [next] | [standalone]

#1722683

Hi,

We are using Linux stable kernel version 4.4.y and would like to see these changes included in that version.
So once these patches are merged in, can they be tagged for other Linux stable kernel releases to pick up these changes? 

Thank you!
Dan

-----Original Message-----
From: Wolfram Sang [mailto:wsa@the-dreams.de] 
Sent: Tuesday, August 29, 2017 7:50 AM
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Steve Douthit <stephend@adiengineering.com>; seth.heasley@intel.com; Dan Priamo <danp@adiengineering.com>; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads


> Sorry, I've been on vacation, yes, the patches look good to me

All fine, I was just being cautious.

> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Thanks!

[toc] | [prev] | [next] | [standalone]

#1722798

[Multipart message — attachments visible in raw view] — view raw

> We are using Linux stable kernel version 4.4.y and would like to see
> these changes included in that version. So once these patches are
> merged in, can they be tagged for other Linux stable kernel releases
> to pick up these changes?

Okay, since I haven't pushed out yet, I can re-apply the bugfix to
for-current and add the stable tag to it.

[toc] | [prev] | [next] | [standalone]

#1722804

Thank you!

-----Original Message-----
From: Wolfram Sang [mailto:wsa@the-dreams.de] 
Sent: Tuesday, August 29, 2017 4:09 PM
To: Dan Priamo <danp@adiengineering.com>
Cc: Neil Horman <nhorman@tuxdriver.com>; Steve Douthit <stephend@adiengineering.com>; seth.heasley@intel.com; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads

> We are using Linux stable kernel version 4.4.y and would like to see 
> these changes included in that version. So once these patches are 
> merged in, can they be tagged for other Linux stable kernel releases 
> to pick up these changes?

Okay, since I haven't pushed out yet, I can re-apply the bugfix to for-current and add the stable tag to it.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web