Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722390
| From | Neil Horman <nhorman@tuxdriver.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads |
| Date | 2017-08-29 13:40 +0200 |
| Message-ID | <ujN29-229-5@gated-at.bofh.it> (permalink) |
| References | <uetnr-8cy-7@gated-at.bofh.it> <uetnr-8cy-5@gated-at.bofh.it> <ujLWq-1pU-19@gated-at.bofh.it> <ujLWq-1pU-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Aug 29, 2017 at 12:22:25PM +0200, Wolfram Sang wrote: > > > >> So basically the byte count already precedes the data in the dma_buffer, > > >> then the driver sticks desc->rxbytes in front of this resulting in the > > >> trace above. > > >> > > >> The first patch tackles this. > > >> > > >> The second patch in the series adds a sanity check on the byte count > > >> supplied by the slave device. This might be a nice to have, but is > > >> probably less critical. > > > > > > Both patches look good to me. Seth, Neil, do you agree? > > > > > > > Ping. > > > > Not sure what the usual review time is, let me know if this is premature. > > I applied both patches to for-next (v4.14) now to get a broader > audience. for-current (v4.13) might have been also applicable, but I > don't want to apply the patches there without the driver maintainer > acks. I hope this works for you. > Sorry, I've been on vacation, yes, the patches look good to me Acked-by: Neil Horman <nhorman@tuxdriver.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 12:30 +0200
Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Neil Horman <nhorman@tuxdriver.com> - 2017-08-29 13:40 +0200
Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 13:50 +0200
RE: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Dan Priamo <danp@adiengineering.com> - 2017-08-29 20:20 +0200
Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 22:10 +0200
RE: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Dan Priamo <danp@adiengineering.com> - 2017-08-29 22:20 +0200
csiph-web