Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720508 > unrolled thread

Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack

Started byBen Hutchings <ben@decadent.org.uk>
First post2017-08-26 02:40 +0200
Last post2017-08-26 02:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on  stack Ben Hutchings <ben@decadent.org.uk> - 2017-08-26 02:40 +0200

#1720508 — Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack

FromBen Hutchings <ben@decadent.org.uk>
Date2017-08-26 02:40 +0200
SubjectRe: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack
Message-ID<uixiN-2At-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

On Sat, 2017-08-19 at 09:29 +0300, Maksim Salau wrote:
> On Fri, 18 Aug 2017 14:13:20 +0100
> Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> > 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Maksim Salau <maksim.salau@gmail.com>
> > 
> > commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
> > 
> > Allocate buffers on HEAP instead of STACK for local structures
> > that are to be received using usb_control_msg().
> 
> Hi Ben,
> 
> The change has a memory leak, which is fixed by the commit
> 0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
> If the commit is not in your queue, please add it.

Thanks, I've added this.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of
them.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web