Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1720508

Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack
Date 2017-08-26 02:40 +0200
Message-ID <uixiN-2At-1@gated-at.bofh.it> (permalink)
References <ufPlT-4d0-3@gated-at.bofh.it> <ufPFh-4ln-49@gated-at.bofh.it> <ug5qF-6cp-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sat, 2017-08-19 at 09:29 +0300, Maksim Salau wrote:
> On Fri, 18 Aug 2017 14:13:20 +0100
> Ben Hutchings <ben@decadent.org.uk> wrote:
> 
> > 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Maksim Salau <maksim.salau@gmail.com>
> > 
> > commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
> > 
> > Allocate buffers on HEAP instead of STACK for local structures
> > that are to be received using usb_control_msg().
> 
> Hi Ben,
> 
> The change has a memory leak, which is fixed by the commit
> 0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
> If the commit is not in your queue, please add it.

Thanks, I've added this.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of
them.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on  stack Ben Hutchings <ben@decadent.org.uk> - 2017-08-26 02:40 +0200

csiph-web