Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720395 > unrolled thread

[PATCH 0/3] SCSI-sg: Adjustments for two function implementations

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] SCSI-sg: Adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200
    [PATCH 2/3] SCSI-sg: Improve a size determination in sg_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200
    [PATCH 3/3] SCSI-sg: Fix a typo in a comment line in sg_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200

#1720395 — [PATCH 0/3] SCSI-sg: Adjustments for two function implementations

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 25 Aug 2017 22:20:02 +0200

A few update suggestions were taken into account
from static source code analysis.

Markus Elfring (3):
  Delete an error message for a failed memory allocation in sg_alloc()
  Improve a size determination in sg_alloc()
  Fix a typo in a comment line in sg_ioctl()

 drivers/scsi/sg.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

-- 
2.14.0

[toc] | [next] | [standalone]

#1720397 — [PATCH 2/3] SCSI-sg: Improve a size determination in sg_alloc()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 25 Aug 2017 21:55:14 +0200

Replace the specification of a data type by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/sg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 8ca10a2fc1a0..4a2db7ff14cc 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -1403,7 +1403,7 @@ sg_alloc(struct gendisk *disk, struct scsi_device *scsidp)
 	int error;
 	u32 k;
 
-	sdp = kzalloc(sizeof(Sg_device), GFP_KERNEL);
+	sdp = kzalloc(sizeof(*sdp), GFP_KERNEL);
 	if (!sdp)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.14.0

[toc] | [prev] | [next] | [standalone]

#1720400 — [PATCH 3/3] SCSI-sg: Fix a typo in a comment line in sg_ioctl()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 25 Aug 2017 22:06:59 +0200

Fix a word in this description.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/scsi/sg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 4a2db7ff14cc..c80899d249c6 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -891,7 +891,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
 	case SG_SET_FORCE_LOW_DMA:
 		/*
 		 * N.B. This ioctl never worked properly, but failed to
-		 * return an error value. So returning '0' to keep compability
+		 * return an error value. So returning '0' to keep compatibility
 		 * with legacy applications.
 		 */
 		return 0;
-- 
2.14.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web