Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720397
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/3] SCSI-sg: Improve a size determination in sg_alloc() |
| Date | 2017-08-25 22:30 +0200 |
| Message-ID | <uitoS-ek-15@gated-at.bofh.it> (permalink) |
| References | <uitoS-ek-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 25 Aug 2017 21:55:14 +0200 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 8ca10a2fc1a0..4a2db7ff14cc 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1403,7 +1403,7 @@ sg_alloc(struct gendisk *disk, struct scsi_device *scsidp) int error; u32 k; - sdp = kzalloc(sizeof(Sg_device), GFP_KERNEL); + sdp = kzalloc(sizeof(*sdp), GFP_KERNEL); if (!sdp) return ERR_PTR(-ENOMEM); -- 2.14.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] SCSI-sg: Adjustments for two function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200 [PATCH 2/3] SCSI-sg: Improve a size determination in sg_alloc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200 [PATCH 3/3] SCSI-sg: Fix a typo in a comment line in sg_ioctl() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-25 22:30 +0200
csiph-web