Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718349 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-08-23 15:30 +0200 |
| Last post | 2017-08-25 02:00 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:30 +0200
Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Randy Dunlap <rdunlap@infradead.org> - 2017-08-23 17:50 +0200
Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-24 01:20 +0200
Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-24 01:30 +0200
Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-24 21:30 +0200
Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-25 02:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-08-23 15:30 +0200 |
| Subject | [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency |
| Message-ID | <uhDTk-14P-17@gated-at.bofh.it> |
Like the version in drivers/net/wireless, this driver requires the
MAC80211 framework, otherwise we run into a link error:
ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
This adds the Kconfig dependency for it.
Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/rtlwifi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
index fc482b49f9aa..cb3a29ae764b 100644
--- a/drivers/staging/rtlwifi/Kconfig
+++ b/drivers/staging/rtlwifi/Kconfig
@@ -1,6 +1,6 @@
config R8822BE
tristate "Realtek RTL8822BE Wireless Network Adapter"
- depends on PCI && m
+ depends on PCI && MAC80211 && m
select FW_LOADER
---help---
This is the staging driver for Realtek RTL8822BE 802.11ac PCIe
--
2.9.0
[toc] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-08-23 17:50 +0200 |
| Message-ID | <uhG4O-2mD-15@gated-at.bofh.it> |
| In reply to | #1718349 |
On 08/23/2017 06:22 AM, Arnd Bergmann wrote:
> Like the version in drivers/net/wireless, this driver requires the
> MAC80211 framework, otherwise we run into a link error:
>
> ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
>
> This adds the Kconfig dependency for it.
Greg,
Please take this patch instead of my patch from yesterday.
Thanks.
> Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/rtlwifi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
> index fc482b49f9aa..cb3a29ae764b 100644
> --- a/drivers/staging/rtlwifi/Kconfig
> +++ b/drivers/staging/rtlwifi/Kconfig
> @@ -1,6 +1,6 @@
> config R8822BE
> tristate "Realtek RTL8822BE Wireless Network Adapter"
> - depends on PCI && m
> + depends on PCI && MAC80211 && m
> select FW_LOADER
> ---help---
> This is the staging driver for Realtek RTL8822BE 802.11ac PCIe
>
--
~Randy
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-08-24 01:20 +0200 |
| Message-ID | <uhN6i-6Uu-15@gated-at.bofh.it> |
| In reply to | #1718468 |
On Wed, Aug 23, 2017 at 08:44:46AM -0700, Randy Dunlap wrote: > On 08/23/2017 06:22 AM, Arnd Bergmann wrote: > > Like the version in drivers/net/wireless, this driver requires the > > MAC80211 framework, otherwise we run into a link error: > > > > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > > > This adds the Kconfig dependency for it. > > Greg, > Please take this patch instead of my patch from yesterday. Ick, already took that one :(
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-08-24 01:30 +0200 |
| Message-ID | <uhNfX-6XI-1@gated-at.bofh.it> |
| In reply to | #1718706 |
On Wed, Aug 23, 2017 at 04:19:08PM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 23, 2017 at 08:44:46AM -0700, Randy Dunlap wrote: > > On 08/23/2017 06:22 AM, Arnd Bergmann wrote: > > > Like the version in drivers/net/wireless, this driver requires the > > > MAC80211 framework, otherwise we run into a link error: > > > > > > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > > > > > This adds the Kconfig dependency for it. > > > > Greg, > > Please take this patch instead of my patch from yesterday. > > Ick, already took that one :( Fixed it up by hand now, all should be good.
[toc] | [prev] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-08-24 21:30 +0200 |
| Message-ID | <ui5Zg-2bY-23@gated-at.bofh.it> |
| In reply to | #1718349 |
On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> Like the version in drivers/net/wireless, this driver requires the
> MAC80211 framework, otherwise we run into a link error:
>
> ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
>
> This adds the Kconfig dependency for it.
>
> Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Greg,
I lost track of which version of this patch you are taking. The one that Randy
Dunlap sent that added NETDEVICES was better than the initial version, but this
one with MAC80211 is the correct one. Randy's patch is in the latest pull I did
on staging.
Do you want an updated patch?
Larry
> ---
> drivers/staging/rtlwifi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
> index fc482b49f9aa..cb3a29ae764b 100644
> --- a/drivers/staging/rtlwifi/Kconfig
> +++ b/drivers/staging/rtlwifi/Kconfig
> @@ -1,6 +1,6 @@
> config R8822BE
> tristate "Realtek RTL8822BE Wireless Network Adapter"
> - depends on PCI && m
> + depends on PCI && MAC80211 && m
> select FW_LOADER
> ---help---
> This is the staging driver for Realtek RTL8822BE 802.11ac PCIe
>
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-08-25 02:00 +0200 |
| Message-ID | <uiacx-4T8-17@gated-at.bofh.it> |
| In reply to | #1719523 |
On Thu, Aug 24, 2017 at 02:23:08PM -0500, Larry Finger wrote:
> On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> > Like the version in drivers/net/wireless, this driver requires the
> > MAC80211 framework, otherwise we run into a link error:
> >
> > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> >
> > This adds the Kconfig dependency for it.
> >
> > Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Greg,
>
> I lost track of which version of this patch you are taking. The one that
> Randy Dunlap sent that added NETDEVICES was better than the initial version,
> but this one with MAC80211 is the correct one. Randy's patch is in the
> latest pull I did on staging.
>
> Do you want an updated patch?
Nope, all should be good now, I've fixed it by hand. Look in my tree
and if it's still wrong there, please send me a fixup.
thanks,
greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web