Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718468

Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency

From Randy Dunlap <rdunlap@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency
Date 2017-08-23 17:50 +0200
Message-ID <uhG4O-2mD-15@gated-at.bofh.it> (permalink)
References <uhDTk-14P-19@gated-at.bofh.it> <uhDTk-14P-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 08/23/2017 06:22 AM, Arnd Bergmann wrote:
> Like the version in drivers/net/wireless, this driver requires the
> MAC80211 framework, otherwise we run into a link error:
> 
> ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> 
> This adds the Kconfig dependency for it.

Greg,
Please take this patch instead of my patch from yesterday.

Thanks.

> Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/staging/rtlwifi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig
> index fc482b49f9aa..cb3a29ae764b 100644
> --- a/drivers/staging/rtlwifi/Kconfig
> +++ b/drivers/staging/rtlwifi/Kconfig
> @@ -1,6 +1,6 @@
>  config R8822BE
>  	tristate "Realtek RTL8822BE Wireless Network Adapter"
> -	depends on PCI && m
> +	depends on PCI && MAC80211 && m
>  	select FW_LOADER
>  	---help---
>  	This is the staging driver for Realtek RTL8822BE 802.11ac PCIe
> 


-- 
~Randy

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Arnd Bergmann <arnd@arndb.de> - 2017-08-23 15:30 +0200
  Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Randy Dunlap <rdunlap@infradead.org> - 2017-08-23 17:50 +0200
    Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-24 01:20 +0200
      Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-24 01:30 +0200
  Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-24 21:30 +0200
    Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-25 02:00 +0200

csiph-web