Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1713364 > unrolled thread

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Greg KH <gregkh@linuxfoundation.org> - 2017-08-17 00:10 +0200
    Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Rishabh Hardas <rishabhhardas@gmail.com> - 2017-08-22 13:30 +0200
      Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-22 14:00 +0200
    Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Rishabh Hardas <rishabhhardas@gmail.com> - 2017-08-22 15:50 +0200
      Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-22 16:00 +0200

#1713364 — Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> From: RishabhHardas <rishabhhardas@gmail.com>
> 
> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> that they were not declared and need to be made static. This patch makes both the symbols
> static inline, to remove the warnings.
> 
> Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>

I doubt you sign your name on legal documents without a ' ' somewhere in
it :(

Please fix up and resend.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1717321

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote:
> On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> > From: RishabhHardas <rishabhhardas@gmail.com>
> > 
> > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> > that they were not declared and need to be made static. This patch makes both the symbols
> > static inline, to remove the warnings.
> > 
> > Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
> 
> I doubt you sign your name on legal documents without a ' ' somewhere in
> it :(
> 
> Please fix up and resend.
> 
> thanks,
> 
> greg k-h
From: Rishabh Hardas <rishabhhardas@gmail.com>

Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be made static. This patch makes both the symbols
static inline, to remove the warnings.

Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
---
 drivers/staging/ccree/ssi_fips.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,1 +40,1 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
 }

 static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

 #endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

[toc] | [prev] | [next] | [standalone]

#1717347

Google for how to send a v2 patch.

https://www.google.com/search?q=how+to+send+a+v2+patch

https://kernelnewbies.org/FirstKernelPatch

regards,
dan carpenter

[toc] | [prev] | [next] | [standalone]

#1717426

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote:
> On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> > From: RishabhHardas <rishabhhardas@gmail.com>
> > 
> > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> > that they were not declared and need to be made static. This patch makes both the symbols
> > static inline, to remove the warnings.
> > 
> > Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
> 
> I doubt you sign your name on legal documents without a ' ' somewhere in
> it :(
> 
> Please fix up and resend.
> 
> thanks,
> 
> greg k-h

From 717ec264a6212b8526c381d3673dd0ee45352266 Mon Sep 17 00:00:00 2001
From: Rishabh Hardas <rishabhhardas@gmail.com>
Date: Tue, 22 Aug 2017 18:56:45 +0530
Subject: [PATCH v2] staging/ccree: Declare compiled out fuctions static inline

Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
---

Changes in v2:
	Corrected my Name.
 drivers/staging/ccree/ssi_fips.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,8 +40,8 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
 }

 static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

 #endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

[toc] | [prev] | [next] | [standalone]

#1717436

Try saving this email and then do `cat email.txt | git am`.  It is
corrupted.  This is not how to send a v2 patch.  Please read:

https://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

Look through the email archives for examples of other v2 patches.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web