Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717321

Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline

Show all headers | View raw

On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote:
> On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote:
> > From: RishabhHardas <rishabhhardas@gmail.com>
> > 
> > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
> > that they were not declared and need to be made static. This patch makes both the symbols
> > static inline, to remove the warnings.
> > 
> > Signed-off-by: RishabhHardas <rishabhhardas@gmail.com>
> 
> I doubt you sign your name on legal documents without a ' ' somewhere in
> it :(
> 
> Please fix up and resend.
> 
> thanks,
> 
> greg k-h
From: Rishabh Hardas <rishabhhardas@gmail.com>

Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be made static. This patch makes both the symbols
static inline, to remove the warnings.

Signed-off-by: Rishabh Hardas <rishabhhardas@gmail.com>
---
 drivers/staging/ccree/ssi_fips.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h
index 369ddf9..63bcca7 100644
--- a/drivers/staging/ccree/ssi_fips.h
+++ b/drivers/staging/ccree/ssi_fips.h
@@ -40,1 +40,1 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata)
 }

 static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {}
-void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
-void fips_handler(struct ssi_drvdata *drvdata) {}
+static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {}
+static inline void fips_handler(struct ssi_drvdata *drvdata) {}

 #endif /* CONFIG_CRYPTO_FIPS */

--
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Greg KH <gregkh@linuxfoundation.org> - 2017-08-17 00:10 +0200
  Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Rishabh Hardas <rishabhhardas@gmail.com> - 2017-08-22 13:30 +0200
    Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-22 14:00 +0200
  Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Rishabh Hardas <rishabhhardas@gmail.com> - 2017-08-22 15:50 +0200
    Re: [PATCH] staging/ccree: Declare compiled out fuctions static  inline Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-22 16:00 +0200

csiph-web