Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712747 > unrolled thread

DSA support for Micrel KSZ8895

Back to article view | Back to linux.kernel

Contents

  DSA support for Micrel KSZ8895 Pavel Machek <pavel@denx.de> - 2017-08-16 10:00 +0200
    Re: DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-16 16:10 +0200
      RE: DSA support for Micrel KSZ8895 <Woojung.Huh@microchip.com> - 2017-08-16 16:30 +0200
        Re: DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-23 14:50 +0200
        RE: DSA support for Micrel KSZ8895 <Woojung.Huh@microchip.com> - 2017-08-23 23:50 +0200
      Re: DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-16 20:40 +0200

#1712747 — DSA support for Micrel KSZ8895

[Multipart message — attachments visible in raw view] — view raw

Hi!

I've got hardware with KSZ8895, and I'd like to use switch ports as
separate ethernet cards. I believe that means DSA support.

And there are even patches available from microchip... unfortunately
they are in strange form and for v3.18.

http://www.microchip.com/SWLibraryWeb/product.aspx?product=KSZ8895%20Software%20Linux%203.18

Is there newer version of the driver available somewhere? Is the
driver good starting point, or should I start with something else?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]

#1712981

On Wed, Aug 16, 2017 at 09:55:24AM +0200, Pavel Machek wrote:
> Hi!
> 
> I've got hardware with KSZ8895, and I'd like to use switch ports as
> separate ethernet cards. I believe that means DSA support.
> 
> And there are even patches available from microchip... unfortunately
> they are in strange form and for v3.18.
> 
> http://www.microchip.com/SWLibraryWeb/product.aspx?product=KSZ8895%20Software%20Linux%203.18
> 
> Is there newer version of the driver available somewhere? Is the
> driver good starting point, or should I start with something else?

Hi Pavel

Woojung is the expert here. His DSA driver for the 9477 is a nice
clean driver.

Have you compared the 8895 to the 9477. Are they similar? Could the
existing 9477 be extended to support the 8895?

	 Andrew

[toc] | [prev] | [next] | [standalone]

#1712998

> > Hi!
> >
> > I've got hardware with KSZ8895, and I'd like to use switch ports as
> > separate ethernet cards. I believe that means DSA support.
> >
> > And there are even patches available from microchip... unfortunately
> > they are in strange form and for v3.18.
> >
> >
> http://www.microchip.com/SWLibraryWeb/product.aspx?product=KSZ8895
> %20Software%20Linux%203.18
> >
> > Is there newer version of the driver available somewhere? Is the
> > driver good starting point, or should I start with something else?
> 
> Hi Pavel
> 
> Woojung is the expert here. His DSA driver for the 9477 is a nice
> clean driver.
> 
> Have you compared the 8895 to the 9477. Are they similar? Could the
> existing 9477 be extended to support the 8895?
> 
> 	 Andrew

Hi Pavel,

I'll forward your email to our support.
AFAIK, KSZ8895 has different register mapping from KSZ9477,
it will be more than ID changes in current driver.

Thanks.
Woojung

[toc] | [prev] | [next] | [standalone]

#1718331

> Any ideas how to do the work in a way to minimize code duplication are
> welcome...

A lot depends on how much duplication there is. mv88e6xxx uses a set
of function points per chip variant. Another option is to put the
common code into a library, and have two drivers. Or if it is the same
registers, but at different locations, you can add a translation
function, which is what i think the b53 driver does.

	  Andrew

[toc] | [prev] | [next] | [standalone]

#1718667

Pavel,

> > I'll forward your email to our support.
> > AFAIK, KSZ8895 has different register mapping from KSZ9477,
> > it will be more than ID changes in current driver.
> 
> More than ID changes, indeed. As layout is completely different, it
> looks like different source file will be needed for support.
> 
> I'm not nearly there; but I can ifconfig lanX up, already, and perform
> some pings.
> 
> Any ideas how to do the work in a way to minimize code duplication are
> welcome...

Which version do you use to create patch?
Getting error when applying patch to the latest net-next.

- Woojung

[toc] | [prev] | [next] | [standalone]

#1713226

[Multipart message — attachments visible in raw view] — view raw

Hi!

> > I've got hardware with KSZ8895, and I'd like to use switch ports as
> > separate ethernet cards. I believe that means DSA support.
> > 
> > And there are even patches available from microchip... unfortunately
> > they are in strange form and for v3.18.
> > 
> > http://www.microchip.com/SWLibraryWeb/product.aspx?product=KSZ8895%20Software%20Linux%203.18
> > 
> > Is there newer version of the driver available somewhere? Is the
> > driver good starting point, or should I start with something else?
> 
> Hi Pavel
> 
> Woojung is the expert here. His DSA driver for the 9477 is a nice
> clean driver.

Good.

> Have you compared the 8895 to the 9477. Are they similar? Could the
> existing 9477 be extended to support the 8895?

Register layouts are completely different, at the very least. I'm not
sure if functionality maps 1:1, that was not exactly easy to check.

I've ported the v3.18 driver to v4.4; it looks like v4.5 port will not
be easy. Plus question is if it works at all... time will tell.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web