Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1718331

Re: DSA support for Micrel KSZ8895

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: DSA support for Micrel KSZ8895
Date 2017-08-23 14:50 +0200
Message-ID <uhDgC-Aw-29@gated-at.bofh.it> (permalink)
References <uf1p8-4gv-31@gated-at.bofh.it> <uf7bb-83I-5@gated-at.bofh.it> <uf7ux-8bJ-3@gated-at.bofh.it> <uhzPH-74N-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> Any ideas how to do the work in a way to minimize code duplication are
> welcome...

A lot depends on how much duplication there is. mv88e6xxx uses a set
of function points per chip variant. Another option is to put the
common code into a library, and have two drivers. Or if it is the same
registers, but at different locations, you can add a translation
function, which is what i think the b53 driver does.

	  Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

DSA support for Micrel KSZ8895 Pavel Machek <pavel@denx.de> - 2017-08-16 10:00 +0200
  Re: DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-16 16:10 +0200
    RE: DSA support for Micrel KSZ8895 <Woojung.Huh@microchip.com> - 2017-08-16 16:30 +0200
      Re: DSA support for Micrel KSZ8895 Andrew Lunn <andrew@lunn.ch> - 2017-08-23 14:50 +0200
      RE: DSA support for Micrel KSZ8895 <Woojung.Huh@microchip.com> - 2017-08-23 23:50 +0200
    Re: DSA support for Micrel KSZ8895 Pavel Machek <pavel@ucw.cz> - 2017-08-16 20:40 +0200

csiph-web