Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718254 > unrolled thread

Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with  "%s: ", __func__ Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-23 13:20 +0200

#1718254 — Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__

On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote:
> Replace hard-coded function names in strings with "%s", __func__ 
> in the olpc_dcon.c file. Issue found by checkpatch.pl.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..3a8d99f 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
> +	pr_info("%s: %lu\n", __func__, output);

This printk doesn't really add anything worthwhile.  Just delete it.

regards,
dan carpenter

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web