Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", func

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__
Date	2017-08-23 13:20 +0200
Message-ID	<uhBRv-8eY-3@gated-at.bofh.it> (permalink)
References	<uhBRv-8eY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote:
> Replace hard-coded function names in strings with "%s", __func__ 
> in the olpc_dcon.c file. Issue found by checkpatch.pl.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..3a8d99f 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
> +	pr_info("%s: %lu\n", __func__, output);

This printk doesn't really add anything worthwhile.  Just delete it.

regards,
dan carpenter

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with  "%s: ", __func__ Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-23 13:20 +0200

csiph-web