Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1718193 > unrolled thread

[PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

Back to article view | Back to linux.kernel

Contents

  [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static Colin King <colin.king@canonical.com> - 2017-08-23 12:00 +0200
    RE: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static "Aviad Krawczyk (A)" <aviad.krawczyk@huawei.com> - 2017-08-23 12:10 +0200
      Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static David Miller <davem@davemloft.net> - 2017-08-23 20:50 +0200
    Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static David Miller <davem@davemloft.net> - 2017-08-24 07:30 +0200

#1718193 — [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin Ian King <colin.king@canonical.com>

The functions set_ctrl0 and set_ctrl1 are local to the source and do
not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'set_ctrl0' was not declared. Should it be static?
symbol 'set_ctrl1' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
index cd09e6ef3aea..7cb8b9b94726 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
@@ -423,7 +423,7 @@ static irqreturn_t ceq_interrupt(int irq, void *data)
 	return IRQ_HANDLED;
 }
 
-void set_ctrl0(struct hinic_eq *eq)
+static void set_ctrl0(struct hinic_eq *eq)
 {
 	struct msix_entry *msix_entry = &eq->msix_entry;
 	enum hinic_eq_type type = eq->type;
@@ -474,7 +474,7 @@ void set_ctrl0(struct hinic_eq *eq)
 	}
 }
 
-void set_ctrl1(struct hinic_eq *eq)
+static void set_ctrl1(struct hinic_eq *eq)
 {
 	enum hinic_eq_type type = eq->type;
 	u32 page_size_val, elem_size;
-- 
2.14.1

[toc] | [next] | [standalone]

#1718207 — RE: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

Thanks

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com] 
Sent: Wednesday, August 23, 2017 1:00 PM
To: Aviad Krawczyk (A); netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin Ian King <colin.king@canonical.com>

The functions set_ctrl0 and set_ctrl1 are local to the source and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'set_ctrl0' was not declared. Should it be static?
symbol 'set_ctrl1' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
index cd09e6ef3aea..7cb8b9b94726 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c
@@ -423,7 +423,7 @@ static irqreturn_t ceq_interrupt(int irq, void *data)
 	return IRQ_HANDLED;
 }
 
-void set_ctrl0(struct hinic_eq *eq)
+static void set_ctrl0(struct hinic_eq *eq)
 {
 	struct msix_entry *msix_entry = &eq->msix_entry;
 	enum hinic_eq_type type = eq->type;
@@ -474,7 +474,7 @@ void set_ctrl0(struct hinic_eq *eq)
 	}
 }
 
-void set_ctrl1(struct hinic_eq *eq)
+static void set_ctrl1(struct hinic_eq *eq)
 {
 	enum hinic_eq_type type = eq->type;
 	u32 page_size_val, elem_size;
--
2.14.1

[toc] | [prev] | [next] | [standalone]

#1718582 — Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: "Aviad Krawczyk (A)" <aviad.krawczyk@huawei.com>
Date: Wed, 23 Aug 2017 10:08:58 +0000

> Thanks

Please do not top-post.

Especially quoting the original message in the way that you did.

As a result of how you replied to this, this patch will show up
twice in my patchwork queue making more administrative work
for me.

Please learn how to properly reply in ASCII text using proper
traditional email quoting mechanisms just like other developers
do on this mailing list.

Every time you do this improperly, you make more work for everyone
on this mailing list.

Thank you.

[toc] | [prev] | [next] | [standalone]

#1718843 — Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From: Colin King <colin.king@canonical.com>
Date: Wed, 23 Aug 2017 10:59:40 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The functions set_ctrl0 and set_ctrl1 are local to the source and do
> not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'set_ctrl0' was not declared. Should it be static?
> symbol 'set_ctrl1' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web