Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static
Date	2017-08-24 07:30 +0200
Message-ID	<uhSSl-2bC-3@gated-at.bofh.it> (permalink)
References	<uhAC7-7kw-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Wed, 23 Aug 2017 10:59:40 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The functions set_ctrl0 and set_ctrl1 are local to the source and do
> not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'set_ctrl0' was not declared. Should it be static?
> symbol 'set_ctrl1' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] net: hinic: make functions set_ctrl0 and set_ctrl1 static Colin King <colin.king@canonical.com> - 2017-08-23 12:00 +0200
  RE: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static "Aviad Krawczyk (A)" <aviad.krawczyk@huawei.com> - 2017-08-23 12:10 +0200
    Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static David Miller <davem@davemloft.net> - 2017-08-23 20:50 +0200
  Re: [PATCH][net-next] net: hinic: make functions set_ctrl0 and  set_ctrl1 static David Miller <davem@davemloft.net> - 2017-08-24 07:30 +0200

csiph-web