Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1715739 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-19 21:10 +0200 |
| Last post | 2017-08-24 11:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] constify rtc i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
[PATCH 2/4] rtc: em3027: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
[PATCH 4/4] rtc: rv3029c2: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
Re: [PATCH 0/4] constify rtc i2c_device_id Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-24 11:10 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 21:10 +0200 |
| Subject | [PATCH 0/4] constify rtc i2c_device_id |
| Message-ID | <ughia-5br-5@gated-at.bofh.it> |
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by <linux/i2c.h> work with const i2c_device_id. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] rtc: ds1672: constify i2c_device_id [PATCH 2/4] rtc: em3027: constify i2c_device_id [PATCH 3/4] rtc: max6900: constify i2c_device_id [PATCH 4/4] rtc: rv3029c2: constify i2c_device_id drivers/rtc/rtc-ds1672.c | 2 +- drivers/rtc/rtc-em3027.c | 2 +- drivers/rtc/rtc-max6900.c | 2 +- drivers/rtc/rtc-rv3029c2.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.4
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 21:10 +0200 |
| Subject | [PATCH 2/4] rtc: em3027: constify i2c_device_id |
| Message-ID | <ughia-5br-13@gated-at.bofh.it> |
| In reply to | #1715739 |
i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/rtc/rtc-em3027.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-em3027.c b/drivers/rtc/rtc-em3027.c
index 4f4930a..b0ef8cf 100644
--- a/drivers/rtc/rtc-em3027.c
+++ b/drivers/rtc/rtc-em3027.c
@@ -132,7 +132,7 @@ static int em3027_probe(struct i2c_client *client,
return 0;
}
-static struct i2c_device_id em3027_id[] = {
+static const struct i2c_device_id em3027_id[] = {
{ "em3027", 0 },
{ }
};
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-19 21:10 +0200 |
| Subject | [PATCH 4/4] rtc: rv3029c2: constify i2c_device_id |
| Message-ID | <ughia-5br-9@gated-at.bofh.it> |
| In reply to | #1715739 |
i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/rtc/rtc-rv3029c2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c
index 85fa1da..aa09771 100644
--- a/drivers/rtc/rtc-rv3029c2.c
+++ b/drivers/rtc/rtc-rv3029c2.c
@@ -868,7 +868,7 @@ static int rv3029_i2c_probe(struct i2c_client *client,
return rv3029_probe(&client->dev, regmap, client->irq, client->name);
}
-static struct i2c_device_id rv3029_id[] = {
+static const struct i2c_device_id rv3029_id[] = {
{ "rv3029", 0 },
{ "rv3029c2", 0 },
{ }
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2017-08-24 11:10 +0200 |
| Message-ID | <uhWjg-4uA-9@gated-at.bofh.it> |
| In reply to | #1715739 |
On 20/08/2017 at 00:37:54 +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by <linux/i2c.h> work with > const i2c_device_id. So mark the non-const structs as const. > > Arvind Yadav (4): > [PATCH 1/4] rtc: ds1672: constify i2c_device_id > [PATCH 2/4] rtc: em3027: constify i2c_device_id > [PATCH 3/4] rtc: max6900: constify i2c_device_id > [PATCH 4/4] rtc: rv3029c2: constify i2c_device_id > > drivers/rtc/rtc-ds1672.c | 2 +- > drivers/rtc/rtc-em3027.c | 2 +- > drivers/rtc/rtc-max6900.c | 2 +- > drivers/rtc/rtc-rv3029c2.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > All applied. > -- > 2.7.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web