Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1715740

[PATCH 2/4] rtc: em3027: constify i2c_device_id

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/4] rtc: em3027: constify i2c_device_id
Date 2017-08-19 21:10 +0200
Message-ID <ughia-5br-13@gated-at.bofh.it> (permalink)
References <ughia-5br-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


i2c_device_id are not supposed to change at runtime. All functions
working with i2c_device_id provided by <linux/i2c.h> work with
const i2c_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/rtc/rtc-em3027.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-em3027.c b/drivers/rtc/rtc-em3027.c
index 4f4930a..b0ef8cf 100644
--- a/drivers/rtc/rtc-em3027.c
+++ b/drivers/rtc/rtc-em3027.c
@@ -132,7 +132,7 @@ static int em3027_probe(struct i2c_client *client,
 	return 0;
 }
 
-static struct i2c_device_id em3027_id[] = {
+static const struct i2c_device_id em3027_id[] = {
 	{ "em3027", 0 },
 	{ }
 };
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] constify rtc i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
  [PATCH 2/4] rtc: em3027: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
  [PATCH 4/4] rtc: rv3029c2: constify i2c_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-19 21:10 +0200
  Re: [PATCH 0/4] constify rtc i2c_device_id Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-08-24 11:10 +0200

csiph-web