Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1711763 > unrolled thread

Re: [PATCH v3 08/13] xen/pvcalls: implement accept command

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 08/13] xen/pvcalls: implement accept command Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-15 04:10 +0200

#1711763 — Re: [PATCH v3 08/13] xen/pvcalls: implement accept command

>> +
>> +    ret = bedata->rsp[req_id].ret;
> 
> You can just return bedata->rsp[req_id].ret;

Or maybe not. The slot may get reused by the time you get to the end.

-boris

> 
> -boris
> 
>> +    /* read ret, then set this rsp slot to be reused */
>> +    smp_mb();
>> +    WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
>> +    WRITE_ONCE(map->passive.inflight_req_id, PVCALLS_INVALID_ID);
>> +    return ret;
>> +}

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web