Re: [PATCH v3 08/13] xen/pvcalls: implement accept command

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 08/13] xen/pvcalls: implement accept command
Date	2017-08-15 04:10 +0200
Message-ID	<uezsS-3CJ-3@gated-at.bofh.it> (permalink)
References	<u9rPj-3Gg-15@gated-at.bofh.it> <u9rPj-3Gg-17@gated-at.bofh.it> <u9rZ0-3YU-33@gated-at.bofh.it> <uezsS-3CJ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>> +
>> +    ret = bedata->rsp[req_id].ret;
> 
> You can just return bedata->rsp[req_id].ret;

Or maybe not. The slot may get reused by the time you get to the end.

-boris

> 
> -boris
> 
>> +    /* read ret, then set this rsp slot to be reused */
>> +    smp_mb();
>> +    WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
>> +    WRITE_ONCE(map->passive.inflight_req_id, PVCALLS_INVALID_ID);
>> +    return ret;
>> +}

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 08/13] xen/pvcalls: implement accept command Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-15 04:10 +0200

csiph-web