Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1711371 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2017-08-14 21:20 +0200 |
| Last post | 2017-08-14 22:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 10/10] lkdtm: Add test for XPFO Kees Cook <keescook@chromium.org> - 2017-08-14 21:20 +0200
Re: [PATCH v5 10/10] lkdtm: Add test for XPFO Tycho Andersen <tycho@docker.com> - 2017-08-14 22:30 +0200
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2017-08-14 21:20 +0200 |
| Subject | Re: [PATCH v5 10/10] lkdtm: Add test for XPFO |
| Message-ID | <uet47-86q-27@gated-at.bofh.it> |
On Wed, Aug 9, 2017 at 1:07 PM, Tycho Andersen <tycho@docker.com> wrote: > From: Juerg Haefliger <juerg.haefliger@hpe.com> > > This test simply reads from userspace memory via the kernel's linear > map. > > hugepages is only supported on x86 right now, hence the ifdef. I'd prefer that the #ifdef is handled in the .c file. The result is that all architectures will have the XPFO_READ_USER_HUGE test, but it can just fail when not available. This means no changes are needed for lkdtm in the future and the test provides an actual test of hugepages coverage. -Kees -- Kees Cook Pixel Security
[toc] | [next] | [standalone]
| From | Tycho Andersen <tycho@docker.com> |
|---|---|
| Date | 2017-08-14 22:30 +0200 |
| Message-ID | <ueu9P-gF-13@gated-at.bofh.it> |
| In reply to | #1711371 |
On Mon, Aug 14, 2017 at 12:10:47PM -0700, Kees Cook wrote: > On Wed, Aug 9, 2017 at 1:07 PM, Tycho Andersen <tycho@docker.com> wrote: > > From: Juerg Haefliger <juerg.haefliger@hpe.com> > > > > This test simply reads from userspace memory via the kernel's linear > > map. > > > > hugepages is only supported on x86 right now, hence the ifdef. > > I'd prefer that the #ifdef is handled in the .c file. The result is > that all architectures will have the XPFO_READ_USER_HUGE test, but it > can just fail when not available. This means no changes are needed for > lkdtm in the future and the test provides an actual test of hugepages > coverage. If failing tests is okay, I think we can just drop that hunk entirely. Everything compiles fine, it just doesn't work :). I'll do that for the next version. Tycho
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web