Re: [PATCH v5 10/10] lkdtm: Add test for XPFO

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 10/10] lkdtm: Add test for XPFO
Date	2017-08-14 21:20 +0200
Message-ID	<uet47-86q-27@gated-at.bofh.it> (permalink)
References	<ucFsJ-3Hw-3@gated-at.bofh.it> <ucFsJ-3Hw-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 9, 2017 at 1:07 PM, Tycho Andersen <tycho@docker.com> wrote:
> From: Juerg Haefliger <juerg.haefliger@hpe.com>
>
> This test simply reads from userspace memory via the kernel's linear
> map.
>
> hugepages is only supported on x86 right now, hence the ifdef.

I'd prefer that the #ifdef is handled in the .c file. The result is
that all architectures will have the XPFO_READ_USER_HUGE test, but it
can just fail when not available. This means no changes are needed for
lkdtm in the future and the test provides an actual test of hugepages
coverage.

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 10/10] lkdtm: Add test for XPFO Kees Cook <keescook@chromium.org> - 2017-08-14 21:20 +0200
  Re: [PATCH v5 10/10] lkdtm: Add test for XPFO Tycho Andersen <tycho@docker.com> - 2017-08-14 22:30 +0200

csiph-web