Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710963 > unrolled thread
| Started by | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| First post | 2017-08-14 16:20 +0200 |
| Last post | 2017-08-14 20:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return Dave Jones <davej@codemonkey.org.uk> - 2017-08-14 16:20 +0200
Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return Christoph Hellwig <hch@lst.de> - 2017-08-14 18:40 +0200
Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return James Smart <jsmart2021@gmail.com> - 2017-08-14 20:00 +0200
| From | Dave Jones <davej@codemonkey.org.uk> |
|---|---|
| Date | 2017-08-14 16:20 +0200 |
| Subject | Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return |
| Message-ID | <ueonL-5bN-13@gated-at.bofh.it> |
On Fri, Aug 11, 2017 at 07:44:19PM +0000, Linux Kernel wrote:
> Web: https://git.kernel.org/torvalds/c/0fb228d30b8d72bfee51f57e638d412324d44a11
> Commit: 0fb228d30b8d72bfee51f57e638d412324d44a11
> Parent: 758f3735580c21b8a36d644128af6608120a1dde
> Refname: refs/heads/master
> Author: James Smart <jsmart2021@gmail.com>
> AuthorDate: Tue Aug 1 15:12:39 2017 -0700
> Committer: Christoph Hellwig <hch@lst.de>
> CommitDate: Thu Aug 10 11:06:38 2017 +0200
>
> nvmet_fc: add defer_req callback for deferment of cmd buffer return
> +
> + /* Cleanup defer'ed IOs in queue */
> + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> + list_del(&deferfcp->req_list);
> + kfree(deferfcp);
> + }
Shouldn't this be list_for_each_entry_safe ?
Dave
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-08-14 18:40 +0200 |
| Subject | Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return |
| Message-ID | <ueqzj-6tX-61@gated-at.bofh.it> |
| In reply to | #1710963 |
On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
> > +
> > + /* Cleanup defer'ed IOs in queue */
> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
> > + list_del(&deferfcp->req_list);
> > + kfree(deferfcp);
> > + }
>
> Shouldn't this be list_for_each_entry_safe ?
It should. James, can you send a fixup?
[toc] | [prev] | [next] | [standalone]
| From | James Smart <jsmart2021@gmail.com> |
|---|---|
| Date | 2017-08-14 20:00 +0200 |
| Message-ID | <uerOG-79Q-43@gated-at.bofh.it> |
| In reply to | #1711212 |
On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>> > +
>> > + /* Cleanup defer'ed IOs in queue */
>> > + list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>> > + list_del(&deferfcp->req_list);
>> > + kfree(deferfcp);
>> > + }
>>
>> Shouldn't this be list_for_each_entry_safe ?
>
> It should. James, can you send a fixup?
>
yes - I was had already identified this fix and in the process of
putting it out.
-- james
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web