Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return

From	James Smart <jsmart2021@gmail.com>
Newsgroups	linux.kernel
Subject	Re: nvmet_fc: add defer_req callback for deferment of cmd buffer return
Date	2017-08-14 20:00 +0200
Message-ID	<uerOG-79Q-43@gated-at.bofh.it> (permalink)
References	<ueonL-5bN-15@gated-at.bofh.it> <ueonL-5bN-13@gated-at.bofh.it> <ueqzj-6tX-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8/14/2017 9:38 AM, Christoph Hellwig wrote:
> On Mon, Aug 14, 2017 at 10:19:24AM -0400, Dave Jones wrote:
>>   > +
>>   > +	/* Cleanup defer'ed IOs in queue */
>>   > +	list_for_each_entry(deferfcp, &queue->avail_defer_list, req_list) {
>>   > +		list_del(&deferfcp->req_list);
>>   > +		kfree(deferfcp);
>>   > +	}
>>
>> Shouldn't this be list_for_each_entry_safe ?
> 
> It should.  James, can you send a fixup?
> 

yes - I was had already identified this fix and in the process of 
putting it out.

-- james

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: nvmet_fc: add defer_req callback for deferment of cmd buffer  return Dave Jones <davej@codemonkey.org.uk> - 2017-08-14 16:20 +0200
  Re: nvmet_fc: add defer_req callback for deferment of cmd buffer         return Christoph Hellwig <hch@lst.de> - 2017-08-14 18:40 +0200
    Re: nvmet_fc: add defer_req callback for deferment of cmd buffer  return James Smart <jsmart2021@gmail.com> - 2017-08-14 20:00 +0200

csiph-web