Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1710596 > unrolled thread

Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init

Started byShawn Lin <shawn.lin@rock-chips.com>
First post2017-08-14 03:20 +0200
Last post2017-08-14 03:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver  init Shawn Lin <shawn.lin@rock-chips.com> - 2017-08-14 03:20 +0200

#1710596 — Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init

FromShawn Lin <shawn.lin@rock-chips.com>
Date2017-08-14 03:20 +0200
SubjectRe: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init
Message-ID<ueccW-64l-5@gated-at.bofh.it>
Trim cc

On 2017/8/11 16:06, Li Wei wrote:
> This commit modifies dw_mci_probe(), it moves reset assertion before
> drv_data->init(host)
> 
> Some driver needs to access controller registers in its .init() ops. So,
> in order to make such access safe, we should do controller reset before
> .init() being called.
> 

LGTM

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Chen Jun <chenjun14@huawei.com>
> ---

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web