Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init

From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver init
Date	2017-08-14 03:20 +0200
Message-ID	<ueccW-64l-5@gated-at.bofh.it> (permalink)
References	<uddb3-14n-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Trim cc

On 2017/8/11 16:06, Li Wei wrote:
> This commit modifies dw_mci_probe(), it moves reset assertion before
> drv_data->init(host)
> 
> Some driver needs to access controller registers in its .init() ops. So,
> in order to make such access safe, we should do controller reset before
> .init() being called.
> 

LGTM

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Wei Li <liwei213@huawei.com>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> Signed-off-by: Chen Jun <chenjun14@huawei.com>
> ---

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v10 1/2] mmc: dw_mmc: move controller reset before driver  init Shawn Lin <shawn.lin@rock-chips.com> - 2017-08-14 03:20 +0200

csiph-web