Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710874 > unrolled thread
| Started by | Bartosz Golaszewski <brgl@bgdev.pl> |
|---|---|
| First post | 2017-08-14 14:00 +0200 |
| Last post | 2017-08-15 11:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 14:00 +0200
Re: [PATCH] irq_work: improve the flag definitions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-14 14:20 +0200
Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 19:20 +0200
Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-15 11:20 +0200
| From | Bartosz Golaszewski <brgl@bgdev.pl> |
|---|---|
| Date | 2017-08-14 14:00 +0200 |
| Subject | [PATCH] irq_work: improve the flag definitions |
| Message-ID | <uemci-3H5-11@gated-at.bofh.it> |
IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
While we're at it: use the BIT() macro for all flags.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
include/linux/irq_work.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
index 47b9ebd4a74f..467a58e7e0da 100644
--- a/include/linux/irq_work.h
+++ b/include/linux/irq_work.h
@@ -12,10 +12,10 @@
* busy NULL, 2 -> {free, claimed} : callback in progress, can be claimed
*/
-#define IRQ_WORK_PENDING 1UL
-#define IRQ_WORK_BUSY 2UL
-#define IRQ_WORK_FLAGS 3UL
-#define IRQ_WORK_LAZY 4UL /* Doesn't want IPI, wait for tick */
+#define IRQ_WORK_PENDING BIT(0)
+#define IRQ_WORK_BUSY BIT(1)
+#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
+#define IRQ_WORK_LAZY BIT(3) /* Doesn't want IPI, wait for tick */
struct irq_work {
unsigned long flags;
--
2.13.2
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-08-14 14:20 +0200 |
| Message-ID | <uemvD-42v-11@gated-at.bofh.it> |
| In reply to | #1710874 |
On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it > says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise > OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. > > While we're at it: use the BIT() macro for all flags. > +#define IRQ_WORK_PENDING BIT(0) > +#define IRQ_WORK_BUSY BIT(1) > +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY) I dunno which style is preferred, though I would go with simple GENMASK() here, as all definitions right on left :-) Parameters of GENMASK will show last-first entries and can be easily decoded. Although there are only two for now. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <brgl@bgdev.pl> |
|---|---|
| Date | 2017-08-14 19:20 +0200 |
| Message-ID | <uerbY-6WD-3@gated-at.bofh.it> |
| In reply to | #1710887 |
2017-08-14 14:19 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>: > On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it >> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise >> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. >> >> While we're at it: use the BIT() macro for all flags. > >> +#define IRQ_WORK_PENDING BIT(0) >> +#define IRQ_WORK_BUSY BIT(1) >> +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY) > > I dunno which style is preferred, though I would go with simple > GENMASK() here, as all definitions right on left :-) > > Parameters of GENMASK will show last-first entries and can be easily decoded. > Although there are only two for now. > Which is a good enough reason to not over-complicate things and just use an easy to decipher bitwise OR. ;) Thanks, Bartosz
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <brgl@bgdev.pl> |
|---|---|
| Date | 2017-08-15 11:20 +0200 |
| Message-ID | <ueGb1-7Uc-41@gated-at.bofh.it> |
| In reply to | #1710874 |
2017-08-14 13:56 GMT+02:00 Bartosz Golaszewski <brgl@bgdev.pl>:
> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>
> While we're at it: use the BIT() macro for all flags.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> include/linux/irq_work.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
> index 47b9ebd4a74f..467a58e7e0da 100644
> --- a/include/linux/irq_work.h
> +++ b/include/linux/irq_work.h
> @@ -12,10 +12,10 @@
> * busy NULL, 2 -> {free, claimed} : callback in progress, can be claimed
> */
>
> -#define IRQ_WORK_PENDING 1UL
> -#define IRQ_WORK_BUSY 2UL
> -#define IRQ_WORK_FLAGS 3UL
> -#define IRQ_WORK_LAZY 4UL /* Doesn't want IPI, wait for tick */
> +#define IRQ_WORK_PENDING BIT(0)
> +#define IRQ_WORK_BUSY BIT(1)
> +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
> +#define IRQ_WORK_LAZY BIT(3) /* Doesn't want IPI, wait for tick */
Superseded by v2 - 4UL is BIT(2), not BIT(3).
Best regards,
Bartosz Golaszewski
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web