Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710485 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-13 13:30 +0200 |
| Last post | 2017-08-13 13:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ACPI / PMIC: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-13 13:30 +0200
Re: [PATCH] ACPI / PMIC: constify platform_device_id Hans de Goede <hdegoede@redhat.com> - 2017-08-13 13:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-13 13:30 +0200 |
| Subject | [PATCH] ACPI / PMIC: constify platform_device_id |
| Message-ID | <udZfH-6yz-3@gated-at.bofh.it> |
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
index 85636d7..813b829 100644
--- a/drivers/acpi/pmic/intel_pmic_chtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
@@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
&intel_cht_wc_pmic_opregion_data);
}
-static struct platform_device_id cht_wc_opregion_id_table[] = {
+static const struct platform_device_id cht_wc_opregion_id_table[] = {
{ .name = "cht_wcove_region" },
{},
};
--
2.7.4
[toc] | [next] | [standalone]
| From | Hans de Goede <hdegoede@redhat.com> |
|---|---|
| Date | 2017-08-13 13:50 +0200 |
| Message-ID | <udZz3-6EJ-1@gated-at.bofh.it> |
| In reply to | #1710485 |
Hi,
On 13-08-17 13:23, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Good catch:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
> index 85636d7..813b829 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
> @@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
> &intel_cht_wc_pmic_opregion_data);
> }
>
> -static struct platform_device_id cht_wc_opregion_id_table[] = {
> +static const struct platform_device_id cht_wc_opregion_id_table[] = {
> { .name = "cht_wcove_region" },
> {},
> };
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web