Re: [PATCH] ACPI / PMIC: constify platform_device_id

From	Hans de Goede <hdegoede@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ACPI / PMIC: constify platform_device_id
Date	2017-08-13 13:50 +0200
Message-ID	<udZz3-6EJ-1@gated-at.bofh.it> (permalink)
References	<udZfH-6yz-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 13-08-17 13:23, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Good catch:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
> index 85636d7..813b829 100644
> --- a/drivers/acpi/pmic/intel_pmic_chtwc.c
> +++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
> @@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
>   			&intel_cht_wc_pmic_opregion_data);
>   }
>   
> -static struct platform_device_id cht_wc_opregion_id_table[] = {
> +static const struct platform_device_id cht_wc_opregion_id_table[] = {
>   	{ .name = "cht_wcove_region" },
>   	{},
>   };
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ACPI / PMIC: constify platform_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-13 13:30 +0200
  Re: [PATCH] ACPI / PMIC: constify platform_device_id Hans de Goede <hdegoede@redhat.com> - 2017-08-13 13:50 +0200

csiph-web