Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1706727 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-08 18:10 +0200 |
| Last post | 2017-08-09 06:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 18:10 +0200
Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-09 06:10 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-08 18:10 +0200 |
| Subject | [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id |
| Message-ID | <ucfeY-2nP-61@gated-at.bofh.it> |
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
index 96c923b..e673bc2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
@@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
#define USB_VENDER_ID_REALTEK 0x0bda
/* 2010-10-19 DID_USB_V3.4 */
-static struct usb_device_id rtl8192c_usb_ids[] = {
+static const struct usb_device_id rtl8192c_usb_ids[] = {
/*=== Realtek demoboard ===*/
/* Default ID */
--
2.7.4
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-08-09 06:10 +0200 |
| Subject | Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id |
| Message-ID | <ucqtH-1Fl-1@gated-at.bofh.it> |
| In reply to | #1706727 |
On 08/08/2017 11:05 AM, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> index 96c923b..e673bc2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
> #define USB_VENDER_ID_REALTEK 0x0bda
>
> /* 2010-10-19 DID_USB_V3.4 */
> -static struct usb_device_id rtl8192c_usb_ids[] = {
> +static const struct usb_device_id rtl8192c_usb_ids[] = {
>
> /*=== Realtek demoboard ===*/
> /* Default ID */
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web