Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id
Date	2017-08-09 06:10 +0200
Message-ID	<ucqtH-1Fl-1@gated-at.bofh.it> (permalink)
References	<ucfeY-2nP-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/08/2017 11:05 AM, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks,

Larry

>   drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> index 96c923b..e673bc2 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c
> @@ -275,7 +275,7 @@ static struct rtl_hal_cfg rtl92cu_hal_cfg = {
>   #define USB_VENDER_ID_REALTEK		0x0bda
>   
>   /* 2010-10-19 DID_USB_V3.4 */
> -static struct usb_device_id rtl8192c_usb_ids[] = {
> +static const struct usb_device_id rtl8192c_usb_ids[] = {
>   
>   	/*=== Realtek demoboard ===*/
>   	/* Default ID */
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 33/35] wireless: realtek: rtl8192cu: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 18:10 +0200
  Re: [PATCH 33/35] wireless: realtek: rtl8192cu: constify  usb_device_id Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-09 06:10 +0200

csiph-web