Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706353 > unrolled thread

[PATCH] omap/hsmmc: constify dev_pm_ops

Started byDoug Wilson <doug.lkml@gmail.com>
First post2017-08-08 13:20 +0200
Last post2017-08-08 13:50 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:20 +0200
    Re: [PATCH] omap/hsmmc: constify dev_pm_ops Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-08 13:40 +0200
      Re: [PATCH] omap/hsmmc: constify dev_pm_ops Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-08 13:50 +0200
        Re: [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:50 +0200
      Re: [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:50 +0200

#1706353 — [PATCH] omap/hsmmc: constify dev_pm_ops

FromDoug Wilson <doug.lkml@gmail.com>
Date2017-08-08 13:20 +0200
Subject[PATCH] omap/hsmmc: constify dev_pm_ops
Message-ID<ucaIh-7zl-9@gated-at.bofh.it>
dev_pm_ops is not supposed to change at runtime. Marking it
constant.

Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
---
 drivers/mmc/host/omap_hsmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 04ff3c9..a280c7f 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
 	return 0;
 }
 
-static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
+static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
 	.runtime_suspend = omap_hsmmc_runtime_suspend,
 	.runtime_resume = omap_hsmmc_runtime_resume,
-- 
2.7.4

[toc] | [next] | [standalone]

#1706393

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-08-08 13:40 +0200
Message-ID<ucb1D-7Kd-7@gated-at.bofh.it>
In reply to#1706353
On 8 August 2017 at 13:14, Doug Wilson <doug.lkml@gmail.com> wrote:
> dev_pm_ops is not supposed to change at runtime. Marking it
> constant.
>
> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>

This doesn't apply on my next branch, please re-base it.

Kind regards
Uffe

> ---
>  drivers/mmc/host/omap_hsmmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 04ff3c9..a280c7f 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
>         return 0;
>  }
>
> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>         SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
>         .runtime_suspend = omap_hsmmc_runtime_suspend,
>         .runtime_resume = omap_hsmmc_runtime_resume,
> --
> 2.7.4
>

[toc] | [prev] | [next] | [standalone]

#1706407

FromUlf Hansson <ulf.hansson@linaro.org>
Date2017-08-08 13:50 +0200
Message-ID<ucbbj-7PZ-7@gated-at.bofh.it>
In reply to#1706393
On 8 August 2017 at 13:39, Doug Wilson <doug.lkml@gmail.com> wrote:
>>>
>>> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
>>
>> This doesn't apply on my next branch, please re-base it.
>
> is this your next-branch :kernel/git/ulfh/mmc.git ?

Correct!

[toc] | [prev] | [next] | [standalone]

#1706412

FromDoug Wilson <doug.lkml@gmail.com>
Date2017-08-08 13:50 +0200
Message-ID<ucbbk-7PZ-23@gated-at.bofh.it>
In reply to#1706407
>>
>> is this your next-branch :kernel/git/ulfh/mmc.git ?
>
> Correct!

The fix is already in your tree. I think you can ignore this patch.

- Doug.

[toc] | [prev] | [next] | [standalone]

#1706408

FromDoug Wilson <doug.lkml@gmail.com>
Date2017-08-08 13:50 +0200
Message-ID<ucbbj-7PZ-9@gated-at.bofh.it>
In reply to#1706393
>>
>> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>
>
> This doesn't apply on my next branch, please re-base it.

is this your next-branch :kernel/git/ulfh/mmc.git ?

- Doug

>>
>> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>>         SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
>>         .runtime_suspend = omap_hsmmc_runtime_suspend,
>>         .runtime_resume = omap_hsmmc_runtime_resume,
>> --
>> 2.7.4
>>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web