Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1706393

Re: [PATCH] omap/hsmmc: constify dev_pm_ops

From Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] omap/hsmmc: constify dev_pm_ops
Date 2017-08-08 13:40 +0200
Message-ID <ucb1D-7Kd-7@gated-at.bofh.it> (permalink)
References <ucaIh-7zl-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 8 August 2017 at 13:14, Doug Wilson <doug.lkml@gmail.com> wrote:
> dev_pm_ops is not supposed to change at runtime. Marking it
> constant.
>
> Signed-off-by: Doug Wilson <doug.wilson@gmail.com>

This doesn't apply on my next branch, please re-base it.

Kind regards
Uffe

> ---
>  drivers/mmc/host/omap_hsmmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 04ff3c9..a280c7f 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2322,7 +2322,7 @@ static int omap_hsmmc_runtime_resume(struct device *dev)
>         return 0;
>  }
>
> -static struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
> +static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = {
>         SET_SYSTEM_SLEEP_PM_OPS(omap_hsmmc_suspend, omap_hsmmc_resume)
>         .runtime_suspend = omap_hsmmc_runtime_suspend,
>         .runtime_resume = omap_hsmmc_runtime_resume,
> --
> 2.7.4
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:20 +0200
  Re: [PATCH] omap/hsmmc: constify dev_pm_ops Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-08 13:40 +0200
    Re: [PATCH] omap/hsmmc: constify dev_pm_ops Ulf Hansson <ulf.hansson@linaro.org> - 2017-08-08 13:50 +0200
      Re: [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:50 +0200
    Re: [PATCH] omap/hsmmc: constify dev_pm_ops Doug Wilson <doug.lkml@gmail.com> - 2017-08-08 13:50 +0200

csiph-web