Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1704777 > unrolled thread

[PATCH 0/8] constify input usb_device_id.

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/8] constify input usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:50 +0200
    [PATCH 8/8] Input: kbtab: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:50 +0200
    Re: [PATCH 0/8] constify input usb_device_id. Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-08 05:10 +0200

#1704777 — [PATCH 0/8] constify input usb_device_id.

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Fix checkpatch.pl error in patch 1,3 and 7:
ERROR: space prohibited before open square bracket '['.

Arvind Yadav (8):
  [PATCH 1/8] Input: iforce: constify usb_device_id and fix space before '[' error.
  [PATCH 2/8] Input: xpad: constify usb_device_id.
  [PATCH 3/8] Input: keyspan_remote: constify usb_device_id.
  [PATCH 4/8] Input: powermate: constify usb_device_id and fix space before '[' error.
  [PATCH 5/8] Input: appletouch: constify usb_device_id.
  [PATCH 6/8] Input: synaptics_usb: constify usb_device_id.
  [PATCH 7/8] Input: acecad: constify usb_device_id and fix space before '[' error.
  [PATCH 8/8] Input: kbtab: constify usb_device_id.

 drivers/input/joystick/iforce/iforce-usb.c | 2 +-
 drivers/input/joystick/xpad.c              | 2 +-
 drivers/input/misc/keyspan_remote.c        | 2 +-
 drivers/input/misc/powermate.c             | 2 +-
 drivers/input/mouse/appletouch.c           | 2 +-
 drivers/input/mouse/synaptics_usb.c        | 2 +-
 drivers/input/tablet/acecad.c              | 2 +-
 drivers/input/tablet/kbtab.c               | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1704778 — [PATCH 8/8] Input: kbtab: constify usb_device_id.

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/input/tablet/kbtab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c
index 4d9d649..a41c3ff 100644
--- a/drivers/input/tablet/kbtab.c
+++ b/drivers/input/tablet/kbtab.c
@@ -88,7 +88,7 @@ static void kbtab_irq(struct urb *urb)
 			__func__, retval);
 }
 
-static struct usb_device_id kbtab_ids[] = {
+static const struct usb_device_id kbtab_ids[] = {
 	{ USB_DEVICE(USB_VENDOR_ID_KBGEAR, 0x1001), .driver_info = 0 },
 	{ }
 };
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1705977

On Sun, Aug 06, 2017 at 01:11:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Fix checkpatch.pl error in patch 1,3 and 7:
> ERROR: space prohibited before open square bracket '['.
> 
> Arvind Yadav (8):
>   [PATCH 1/8] Input: iforce: constify usb_device_id and fix space before '[' error.
>   [PATCH 2/8] Input: xpad: constify usb_device_id.
>   [PATCH 3/8] Input: keyspan_remote: constify usb_device_id.
>   [PATCH 4/8] Input: powermate: constify usb_device_id and fix space before '[' error.
>   [PATCH 5/8] Input: appletouch: constify usb_device_id.
>   [PATCH 6/8] Input: synaptics_usb: constify usb_device_id.
>   [PATCH 7/8] Input: acecad: constify usb_device_id and fix space before '[' error.
>   [PATCH 8/8] Input: kbtab: constify usb_device_id.
> 
>  drivers/input/joystick/iforce/iforce-usb.c | 2 +-
>  drivers/input/joystick/xpad.c              | 2 +-
>  drivers/input/misc/keyspan_remote.c        | 2 +-
>  drivers/input/misc/powermate.c             | 2 +-
>  drivers/input/mouse/appletouch.c           | 2 +-
>  drivers/input/mouse/synaptics_usb.c        | 2 +-
>  drivers/input/tablet/acecad.c              | 2 +-
>  drivers/input/tablet/kbtab.c               | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

Applied the lot, thank you.

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web