Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1703249 > unrolled thread

[PATCH 0/6] constify mtd pci_device_id

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-03 18:30 +0200
Last post2017-08-03 18:30 +0200
Articles 5 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/6] constify mtd pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200
    [PATCH 2/6] mtd: amd76xrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200
    [PATCH 4/6] mtd: ck804xrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200
    [PATCH 1/6] mtd: ichxrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200
    [PATCH 3/6] mtd: esb2rom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200

#1703249 — [PATCH 0/6] constify mtd pci_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 18:30 +0200
Subject[PATCH 0/6] constify mtd pci_device_id
Message-ID<uarax-2uN-3@gated-at.bofh.it>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Arvind Yadav (6):
  [PATCH 1/6] mtd: maps: ichxrom: constify pci_device_id.
  [PATCH 2/6] mtd: amd76xrom: constify pci_device_id.
  [PATCH 3/6] mtd: esb2rom: constify pci_device_id.
  [PATCH 4/6] mtd: ck804xrom: constify pci_device_id.
  [PATCH 5/6] mtd: intel_vr_nor: constify pci_device_id.
  [PATCH 6/6] mtd: pci: constify pci_device_id.

 drivers/mtd/maps/amd76xrom.c    | 4 ++--
 drivers/mtd/maps/ck804xrom.c    | 4 ++--
 drivers/mtd/maps/esb2rom.c      | 4 ++--
 drivers/mtd/maps/ichxrom.c      | 4 ++--
 drivers/mtd/maps/intel_vr_nor.c | 2 +-
 drivers/mtd/maps/pci.c          | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]


#1703250 — [PATCH 2/6] mtd: amd76xrom: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 18:30 +0200
Subject[PATCH 2/6] mtd: amd76xrom: constify pci_device_id.
Message-ID<uaray-2uN-21@gated-at.bofh.it>
In reply to#1703249
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mtd/maps/amd76xrom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/maps/amd76xrom.c b/drivers/mtd/maps/amd76xrom.c
index f2b6866..26de0a1 100644
--- a/drivers/mtd/maps/amd76xrom.c
+++ b/drivers/mtd/maps/amd76xrom.c
@@ -296,7 +296,7 @@ static void amd76xrom_remove_one(struct pci_dev *pdev)
 	amd76xrom_cleanup(window);
 }
 
-static struct pci_device_id amd76xrom_pci_tbl[] = {
+static const struct pci_device_id amd76xrom_pci_tbl[] = {
 	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_VIPER_7410,
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_VIPER_7440,
@@ -319,7 +319,7 @@ static struct pci_driver amd76xrom_driver = {
 static int __init init_amd76xrom(void)
 {
 	struct pci_dev *pdev;
-	struct pci_device_id *id;
+	const struct pci_device_id *id;
 	pdev = NULL;
 	for(id = amd76xrom_pci_tbl; id->vendor; id++) {
 		pdev = pci_get_device(id->vendor, id->device, NULL);
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1703253 — [PATCH 4/6] mtd: ck804xrom: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 18:30 +0200
Subject[PATCH 4/6] mtd: ck804xrom: constify pci_device_id.
Message-ID<uaraz-2uN-27@gated-at.bofh.it>
In reply to#1703249
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mtd/maps/ck804xrom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/maps/ck804xrom.c b/drivers/mtd/maps/ck804xrom.c
index 4f206a9..584962e 100644
--- a/drivers/mtd/maps/ck804xrom.c
+++ b/drivers/mtd/maps/ck804xrom.c
@@ -326,7 +326,7 @@ static void ck804xrom_remove_one(struct pci_dev *pdev)
 	ck804xrom_cleanup(window);
 }
 
-static struct pci_device_id ck804xrom_pci_tbl[] = {
+static const struct pci_device_id ck804xrom_pci_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0051), .driver_data = DEV_CK804 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0360), .driver_data = DEV_MCP55 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0361), .driver_data = DEV_MCP55 },
@@ -353,7 +353,7 @@ static struct pci_driver ck804xrom_driver = {
 static int __init init_ck804xrom(void)
 {
 	struct pci_dev *pdev;
-	struct pci_device_id *id;
+	const struct pci_device_id *id;
 	int retVal;
 	pdev = NULL;
 
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1703254 — [PATCH 1/6] mtd: ichxrom: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 18:30 +0200
Subject[PATCH 1/6] mtd: ichxrom: constify pci_device_id.
Message-ID<uaraz-2uN-29@gated-at.bofh.it>
In reply to#1703249
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mtd/maps/ichxrom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/maps/ichxrom.c b/drivers/mtd/maps/ichxrom.c
index 976d42f..1888c5b 100644
--- a/drivers/mtd/maps/ichxrom.c
+++ b/drivers/mtd/maps/ichxrom.c
@@ -323,7 +323,7 @@ static void ichxrom_remove_one(struct pci_dev *pdev)
 	ichxrom_cleanup(window);
 }
 
-static struct pci_device_id ichxrom_pci_tbl[] = {
+static const struct pci_device_id ichxrom_pci_tbl[] = {
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_0,
 	  PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_0,
@@ -351,7 +351,7 @@ static struct pci_driver ichxrom_driver = {
 static int __init init_ichxrom(void)
 {
 	struct pci_dev *pdev;
-	struct pci_device_id *id;
+	const struct pci_device_id *id;
 
 	pdev = NULL;
 	for (id = ichxrom_pci_tbl; id->vendor; id++) {
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]


#1703257 — [PATCH 3/6] mtd: esb2rom: constify pci_device_id.

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-03 18:30 +0200
Subject[PATCH 3/6] mtd: esb2rom: constify pci_device_id.
Message-ID<uaraz-2uN-37@gated-at.bofh.it>
In reply to#1703249
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/mtd/maps/esb2rom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/maps/esb2rom.c b/drivers/mtd/maps/esb2rom.c
index 9646b07..da9f6d7 100644
--- a/drivers/mtd/maps/esb2rom.c
+++ b/drivers/mtd/maps/esb2rom.c
@@ -384,7 +384,7 @@ static void esb2rom_remove_one(struct pci_dev *pdev)
 	esb2rom_cleanup(window);
 }
 
-static struct pci_device_id esb2rom_pci_tbl[] = {
+static const struct pci_device_id esb2rom_pci_tbl[] = {
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_0,
 	  PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801CA_0,
@@ -414,7 +414,7 @@ static struct pci_driver esb2rom_driver = {
 static int __init init_esb2rom(void)
 {
 	struct pci_dev *pdev;
-	struct pci_device_id *id;
+	const struct pci_device_id *id;
 	int retVal;
 
 	pdev = NULL;
-- 
2.7.4

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web