Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1703250
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/6] mtd: amd76xrom: constify pci_device_id. |
| Date | 2017-08-03 18:30 +0200 |
| Message-ID | <uaray-2uN-21@gated-at.bofh.it> (permalink) |
| References | <uarax-2uN-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mtd/maps/amd76xrom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/maps/amd76xrom.c b/drivers/mtd/maps/amd76xrom.c
index f2b6866..26de0a1 100644
--- a/drivers/mtd/maps/amd76xrom.c
+++ b/drivers/mtd/maps/amd76xrom.c
@@ -296,7 +296,7 @@ static void amd76xrom_remove_one(struct pci_dev *pdev)
amd76xrom_cleanup(window);
}
-static struct pci_device_id amd76xrom_pci_tbl[] = {
+static const struct pci_device_id amd76xrom_pci_tbl[] = {
{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_VIPER_7410,
PCI_ANY_ID, PCI_ANY_ID, },
{ PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_VIPER_7440,
@@ -319,7 +319,7 @@ static struct pci_driver amd76xrom_driver = {
static int __init init_amd76xrom(void)
{
struct pci_dev *pdev;
- struct pci_device_id *id;
+ const struct pci_device_id *id;
pdev = NULL;
for(id = amd76xrom_pci_tbl; id->vendor; id++) {
pdev = pci_get_device(id->vendor, id->device, NULL);
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] constify mtd pci_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200 [PATCH 2/6] mtd: amd76xrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200 [PATCH 4/6] mtd: ck804xrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200 [PATCH 1/6] mtd: ichxrom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200 [PATCH 3/6] mtd: esb2rom: constify pci_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 18:30 +0200
csiph-web