Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702959 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-03 13:30 +0200 |
| Last post | 2017-08-03 13:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/4] constify hid attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 13:30 +0200
Re: [PATCH 0/4] constify hid attribute_group structures. Jiri Kosina <jikos@kernel.org> - 2017-08-03 13:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-03 13:30 +0200 |
| Subject | [PATCH 0/4] constify hid attribute_group structures. |
| Message-ID | <uamud-7FZ-7@gated-at.bofh.it> |
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. Arvind Yadav (5): [PATCH 1/4] HID: multitouch: constify attribute_group structures. [PATCH 2/4] HID: sensor: constify attribute_group structures. [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures. [PATCH 4/4] HID: ntrig: constify attribute_group structures. drivers/hid/hid-logitech-hidpp.c | 2 +- drivers/hid/hid-multitouch.c | 2 +- drivers/hid/hid-ntrig.c | 2 +- drivers/hid/hid-sensor-custom.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1
[toc] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-08-03 13:50 +0200 |
| Message-ID | <uamNA-7Pj-21@gated-at.bofh.it> |
| In reply to | #1702959 |
On Thu, 3 Aug 2017, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by <linux/sysfs.h> work with > const attribute_group. So mark the non-const structs as const. > > Arvind Yadav (5): > [PATCH 1/4] HID: multitouch: constify attribute_group structures. > [PATCH 2/4] HID: sensor: constify attribute_group structures. > [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures. > [PATCH 4/4] HID: ntrig: constify attribute_group structures. > > drivers/hid/hid-logitech-hidpp.c | 2 +- > drivers/hid/hid-multitouch.c | 2 +- > drivers/hid/hid-ntrig.c | 2 +- > drivers/hid/hid-sensor-custom.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) I've applied this to for-4.14/constify-attribute_group branch, but please fix your workflow for any furture submissions -- the series wasn't properly threaded, only patch 1/4 got threaded to 0/4 mail, others were missing References/In-reply-to header completely. Thanks, -- Jiri Kosina SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web