Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702981

Re: [PATCH 0/4] constify hid attribute_group structures.

Show all headers | View raw

On Thu, 3 Aug 2017, Arvind Yadav wrote:

> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
> 
> Arvind Yadav (5):
>   [PATCH 1/4] HID: multitouch: constify attribute_group structures.
>   [PATCH 2/4] HID: sensor: constify attribute_group structures.
>   [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures.
>   [PATCH 4/4] HID: ntrig: constify attribute_group structures.
> 
>  drivers/hid/hid-logitech-hidpp.c |  2 +-
>  drivers/hid/hid-multitouch.c     |  2 +-
>  drivers/hid/hid-ntrig.c          |  2 +-
>  drivers/hid/hid-sensor-custom.c  |  2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

I've applied this to for-4.14/constify-attribute_group branch, but please 
fix your workflow for any furture submissions -- the series wasn't 
properly threaded, only patch 1/4 got threaded to 0/4 mail, others were 
missing References/In-reply-to header completely.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] constify hid attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-03 13:30 +0200
  Re: [PATCH 0/4] constify hid attribute_group structures. Jiri Kosina <jikos@kernel.org> - 2017-08-03 13:50 +0200

csiph-web