Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702743 > unrolled thread
| Started by | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| First post | 2017-08-03 10:00 +0200 |
| Last post | 2017-08-03 11:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 01/13] mpt3sas: Update MPI Header Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-03 10:00 +0200
Re: [PATCH v2 01/13] mpt3sas: Update MPI Header Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-08-03 11:40 +0200
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2017-08-03 10:00 +0200 |
| Subject | Re: [PATCH v2 01/13] mpt3sas: Update MPI Header |
| Message-ID | <uajcZ-5jY-11@gated-at.bofh.it> |
On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote: > > + U32 > > + IOCLogInfo; /*0x10 */ > > + U16 > > + ErrorResponseCount; /*0x14 */ > > + U16 > > + Reserved4; /*0x16 */ > > +} MPI26_NVME_ENCAPSULATED_ERROR_REPLY, > > + *PTR_MPI26_NVME_ENCAPSULATED_ERROR_REPLY, > > + Mpi26NVMeEncapsulatedErrorReply_t, > > + *pMpi26NVMeEncapsulatedErrorReply_t; > > + > > + > > +#endif > > + > > + > Very odd indentation. > Please reformat to have type and variable on one line. And use Linux types and no CamelCase and no typedefs (especially not for pointers), you're not on Windows here. Thanks, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [next] | [standalone]
| From | Sreekanth Reddy <sreekanth.reddy@broadcom.com> |
|---|---|
| Date | 2017-08-03 11:40 +0200 |
| Message-ID | <uakLL-6tI-1@gated-at.bofh.it> |
| In reply to | #1702743 |
On Thu, Aug 3, 2017 at 1:25 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote: >> > + U32 >> > + IOCLogInfo; /*0x10 */ >> > + U16 >> > + ErrorResponseCount; /*0x14 */ >> > + U16 >> > + Reserved4; /*0x16 */ >> > +} MPI26_NVME_ENCAPSULATED_ERROR_REPLY, >> > + *PTR_MPI26_NVME_ENCAPSULATED_ERROR_REPLY, >> > + Mpi26NVMeEncapsulatedErrorReply_t, >> > + *pMpi26NVMeEncapsulatedErrorReply_t; >> > + >> > + >> > +#endif >> > + >> > + >> Very odd indentation. >> Please reformat to have type and variable on one line. > > And use Linux types and no CamelCase and no typedefs (especially not for > pointers), you're not on Windows here. We will reformat to have type and variable on one line as suggested by Hannes. But it will be going have a huge change in the driver, if we want to remove the CamelCase and typedefs. From legacy days onwards mpi headers has the CamelCase type variable names and the same variables are used in the code in large number of places. Also our MPI headers are common across the OS platforms and so maintaining mpi headers updates will be more difficult. Thanks, Sreekanth > > Thanks, > Johannes > > -- > Johannes Thumshirn Storage > jthumshirn@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web