Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

From	Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 01/13] mpt3sas: Update MPI Header
Date	2017-08-03 11:40 +0200
Message-ID	<uakLL-6tI-1@gated-at.bofh.it> (permalink)
References	<u38Po-413-5@gated-at.bofh.it> <u38Pp-413-43@gated-at.bofh.it> <uahNU-4ra-5@gated-at.bofh.it> <uajcZ-5jY-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 3, 2017 at 1:25 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote:
> On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote:
>> > +   U32
>> > +           IOCLogInfo;                     /*0x10 */
>> > +   U16
>> > +           ErrorResponseCount;             /*0x14 */
>> > +   U16
>> > +           Reserved4;                      /*0x16 */
>> > +} MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
>> > +   *PTR_MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
>> > +   Mpi26NVMeEncapsulatedErrorReply_t,
>> > +   *pMpi26NVMeEncapsulatedErrorReply_t;
>> > +
>> > +
>> > +#endif
>> > +
>> > +
>> Very odd indentation.
>> Please reformat to have type and variable on one line.
>
> And use Linux types and no CamelCase and no typedefs (especially not for
> pointers), you're not on Windows here.

We will reformat to have type and variable on one line as suggested by Hannes.

But it will be going have a huge change in the driver, if we want to
remove the CamelCase and typedefs. From legacy days onwards mpi
headers has the CamelCase type variable names and the same variables
are used in the code in large number of places. Also our MPI headers
are common across the OS platforms and so maintaining mpi headers
updates will be more difficult.

Thanks,
Sreekanth

>
> Thanks,
>         Johannes
>
> --
> Johannes Thumshirn                                          Storage
> jthumshirn@suse.de                                +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-03 10:00 +0200
  Re: [PATCH v2 01/13] mpt3sas: Update MPI Header Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-08-03 11:40 +0200

csiph-web