Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703745 > unrolled thread

[PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed Michal Simek <michal.simek@xilinx.com> - 2017-08-04 09:40 +0200
    Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver  is probed Guenter Roeck <linux@roeck-us.net> - 2017-08-04 15:50 +0200
      Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver  is probed Michal Simek <monstr@monstr.eu> - 2017-08-04 16:00 +0200

#1703745 — [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

Showing message that driver is loaded is common across drivers.
This change also fixes checkpatch (--strict) warning
"Alignment should match open parenthesis".

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/watchdog/cadence_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
index dadd3b0c2d49..064cf7b6c1c5 100644
--- a/drivers/watchdog/cadence_wdt.c
+++ b/drivers/watchdog/cadence_wdt.c
@@ -368,7 +368,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
 	}
 	platform_set_drvdata(pdev, wdt);
 
-	dev_dbg(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
+	dev_info(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
 		 wdt->regs, cdns_wdt_device->timeout,
 		 nowayout ? ", nowayout" : "");
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1704005 — Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

On 08/04/2017 12:39 AM, Michal Simek wrote:
> Showing message that driver is loaded is common across drivers.

Across watchdog drivers, which I am always half-annoyed about.
Is this really valuable ?

Guenter

> This change also fixes checkpatch (--strict) warning
> "Alignment should match open parenthesis".
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>   drivers/watchdog/cadence_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index dadd3b0c2d49..064cf7b6c1c5 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -368,7 +368,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   	}
>   	platform_set_drvdata(pdev, wdt);
>   
> -	dev_dbg(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> +	dev_info(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
>   		 wdt->regs, cdns_wdt_device->timeout,
>   		 nowayout ? ", nowayout" : "");
>   
> 

[toc] | [prev] | [next] | [standalone]

#1704012 — Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

[Multipart message — attachments visible in raw view] — view raw

On 4.8.2017 15:47, Guenter Roeck wrote:
> On 08/04/2017 12:39 AM, Michal Simek wrote:
>> Showing message that driver is loaded is common across drivers.
> 
> Across watchdog drivers, which I am always half-annoyed about.
> Is this really valuable ?

I don't think that this is debug message. We don't have hundreds of
drivers that log explodes and for systems, which I don't know, I do
normally check dmesg logs and I would expect this message to be there to
know that watchdog is enabled.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web