Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1704005

Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed
Date 2017-08-04 15:50 +0200
Message-ID <uaL9g-7DN-29@gated-at.bofh.it> (permalink)
References <uaFnb-42L-13@gated-at.bofh.it> <uaFnb-42L-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 08/04/2017 12:39 AM, Michal Simek wrote:
> Showing message that driver is loaded is common across drivers.

Across watchdog drivers, which I am always half-annoyed about.
Is this really valuable ?

Guenter

> This change also fixes checkpatch (--strict) warning
> "Alignment should match open parenthesis".
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>   drivers/watchdog/cadence_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index dadd3b0c2d49..064cf7b6c1c5 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -368,7 +368,7 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>   	}
>   	platform_set_drvdata(pdev, wdt);
>   
> -	dev_dbg(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> +	dev_info(&pdev->dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
>   		 wdt->regs, cdns_wdt_device->timeout,
>   		 nowayout ? ", nowayout" : "");
>   
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] watchdog: cadence_wdt: Show information when driver is probed Michal Simek <michal.simek@xilinx.com> - 2017-08-04 09:40 +0200
  Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver  is probed Guenter Roeck <linux@roeck-us.net> - 2017-08-04 15:50 +0200
    Re: [PATCH 2/2] watchdog: cadence_wdt: Show information when driver  is probed Michal Simek <monstr@monstr.eu> - 2017-08-04 16:00 +0200

csiph-web