Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702458 > unrolled thread
| Started by | Eric Anholt <eric@anholt.net> |
|---|---|
| First post | 2017-08-02 22:40 +0200 |
| Last post | 2017-08-04 12:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. Eric Anholt <eric@anholt.net> - 2017-08-02 22:40 +0200
Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. Noralf Trønnes <noralf@tronnes.org> - 2017-08-02 23:00 +0200
Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-04 12:10 +0200
| From | Eric Anholt <eric@anholt.net> |
|---|---|
| Date | 2017-08-02 22:40 +0200 |
| Subject | [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. |
| Message-ID | <ua8AV-6r3-7@gated-at.bofh.it> |
It's also destroyed from the top level vc4_drv.c initialization, which
is where the cache was actually initialized from.
This used to just involve duplicate del_timer() and cancel_work_sync()
being called, but it started causing kmalloc issues once we
double-freed the new BO label array.
Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/vc4/vc4_gem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 209fccd0d3b4..892a031a3ced 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev)
if (vc4->hang_state)
vc4_free_hang_state(dev, vc4->hang_state);
-
- vc4_bo_cache_destroy(dev);
}
--
2.13.3
[toc] | [next] | [standalone]
| From | Noralf Trønnes <noralf@tronnes.org> |
|---|---|
| Date | 2017-08-02 23:00 +0200 |
| Subject | Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. |
| Message-ID | <ua8Uh-6yA-3@gated-at.bofh.it> |
| In reply to | #1702458 |
Den 02.08.2017 22.32, skrev Eric Anholt:
> It's also destroyed from the top level vc4_drv.c initialization, which
> is where the cache was actually initialized from.
>
> This used to just involve duplicate del_timer() and cancel_work_sync()
> being called, but it started causing kmalloc issues once we
> double-freed the new BO label array.
>
> Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/vc4/vc4_gem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
> index 209fccd0d3b4..892a031a3ced 100644
> --- a/drivers/gpu/drm/vc4/vc4_gem.c
> +++ b/drivers/gpu/drm/vc4/vc4_gem.c
> @@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev)
>
> if (vc4->hang_state)
> vc4_free_hang_state(dev, vc4->hang_state);
> -
> - vc4_bo_cache_destroy(dev);
> }
I don't have a display connected, but there's no crashing anymore.
Tested-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
[toc] | [prev] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-08-04 12:10 +0200 |
| Subject | Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. |
| Message-ID | <uaHIl-5DP-1@gated-at.bofh.it> |
| In reply to | #1702458 |
On Wed, 2 Aug 2017 13:32:40 -0700
Eric Anholt <eric@anholt.net> wrote:
> It's also destroyed from the top level vc4_drv.c initialization, which
> is where the cache was actually initialized from.
>
> This used to just involve duplicate del_timer() and cancel_work_sync()
> being called, but it started causing kmalloc issues once we
> double-freed the new BO label array.
>
> Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/gpu/drm/vc4/vc4_gem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
> index 209fccd0d3b4..892a031a3ced 100644
> --- a/drivers/gpu/drm/vc4/vc4_gem.c
> +++ b/drivers/gpu/drm/vc4/vc4_gem.c
> @@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev)
>
> if (vc4->hang_state)
> vc4_free_hang_state(dev, vc4->hang_state);
> -
> - vc4_bo_cache_destroy(dev);
> }
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web