[PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown.
Date	2017-08-02 22:40 +0200
Message-ID	<ua8AV-6r3-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

It's also destroyed from the top level vc4_drv.c initialization, which
is where the cache was actually initialized from.

This used to just involve duplicate del_timer() and cancel_work_sync()
being called, but it started causing kmalloc issues once we
double-freed the new BO label array.

Fixes: 1908a876f909 ("drm/vc4: Add an ioctl for labeling GEM BOs for summary stats")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_gem.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
index 209fccd0d3b4..892a031a3ced 100644
--- a/drivers/gpu/drm/vc4/vc4_gem.c
+++ b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -1117,6 +1117,4 @@ vc4_gem_destroy(struct drm_device *dev)
 
 	if (vc4->hang_state)
 		vc4_free_hang_state(dev, vc4->hang_state);
-
-	vc4_bo_cache_destroy(dev);
 }
-- 
2.13.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown. Eric Anholt <eric@anholt.net> - 2017-08-02 22:40 +0200
  Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on  teardown. Noralf Trønnes <noralf@tronnes.org> - 2017-08-02 23:00 +0200
  Re: [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on  teardown. Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-04 12:10 +0200

csiph-web