Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1702047 > unrolled thread
| Started by | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| First post | 2017-08-02 14:00 +0200 |
| Last post | 2017-08-03 23:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init() Linus Walleij <linus.walleij@linaro.org> - 2017-08-02 14:00 +0200
Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-03 23:50 +0200
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-08-02 14:00 +0200 |
| Subject | Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init() |
| Message-ID | <ua0tH-Vn-5@gated-at.bofh.it> |
On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > Remove unnecessary static on local variable syscon_regmap. > Such variables are initialized before being used, on every > execution path throughout the functions. So, the static has > no benefit. > > This issue was detected using Coccinelle and the following > semantic patch: > > @bad exists@ > position p; > identifier x; > type T; > @@ > > static T x@p; > ... > x = <+...x...+> > > @@ > identifier x; > expression e; > type T; > position p != bad.p; > @@ > > -static > T x@p; > ... when != x > when strict > ?x = e; > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> You probably want to funnel this patch through the ARM SoC tree. Yours, Linus Walleij
[toc] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-08-03 23:50 +0200 |
| Subject | Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init() |
| Message-ID | <uawae-5UG-37@gated-at.bofh.it> |
| In reply to | #1702047 |
Hi Linus, On 08/02/2017 06:58 AM, Linus Walleij wrote: > On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: > >> Remove unnecessary static on local variable syscon_regmap. >> Such variables are initialized before being used, on every >> execution path throughout the functions. So, the static has >> no benefit. >> >> This issue was detected using Coccinelle and the following >> semantic patch: >> >> @bad exists@ >> position p; >> identifier x; >> type T; >> @@ >> >> static T x@p; >> ... >> x = <+...x...+> >> >> @@ >> identifier x; >> expression e; >> type T; >> position p != bad.p; >> @@ >> >> -static >> T x@p; >> ... when != x >> when strict >> ?x = e; >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > You probably want to funnel this patch through the ARM SoC tree. > I'll do that. I'll add your ACK and CC you. Thanks -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web