Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1702047

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

Show all headers | View raw

On Thu, Jul 20, 2017 at 12:39 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:

> Remove unnecessary static on local variable syscon_regmap.
> Such variables are initialized before being used, on every
> execution path throughout the functions. So, the static has
> no benefit.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
>
> static T x@p;
> ...
> x = <+...x...+>
>
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
>
> -static
>  T x@p;
>  ... when != x
>      when strict
> ?x = e;
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

You probably want to funnel this patch through the ARM SoC tree.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] soc: integrator: remove unnecessary static in integrator_soc_init() Linus Walleij <linus.walleij@linaro.org> - 2017-08-02 14:00 +0200
  Re: [PATCH] soc: integrator: remove unnecessary static in  integrator_soc_init() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-03 23:50 +0200

csiph-web