Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1700371 > unrolled thread

Re: security/apparmor/label.c:1498]: (style) Redundant condition

Started byJohn Johansen <john.johansen@canonical.com>
First post2017-07-31 22:20 +0200
Last post2017-07-31 22:20 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: security/apparmor/label.c:1498]: (style) Redundant condition John Johansen <john.johansen@canonical.com> - 2017-07-31 22:20 +0200

#1700371 — Re: security/apparmor/label.c:1498]: (style) Redundant condition

FromJohn Johansen <john.johansen@canonical.com>
Date2017-07-31 22:20 +0200
SubjectRe: security/apparmor/label.c:1498]: (style) Redundant condition
Message-ID<u9pku-2jJ-17@gated-at.bofh.it>
On 07/17/2017 12:34 AM, David Binderman wrote:
> Hello there,
> 
> 
> security/apparmor/label.c:1498]: (style) Redundant condition: prev_ns. '!prev_ns || (prev_ns && *prev_ns!=profile->ns)' is equivalent to '!prev_ns || *prev_ns!=profile->ns'
> 
> Source code is
> 
>     if (view != profile->ns &&
>         (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
> 

yep, I will add the fix to the next pull request

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web