Re: security/apparmor/label.c:1498]: (style) Redundant condition

From	John Johansen <john.johansen@canonical.com>
Newsgroups	linux.kernel
Subject	Re: security/apparmor/label.c:1498]: (style) Redundant condition
Date	2017-07-31 22:20 +0200
Message-ID	<u9pku-2jJ-17@gated-at.bofh.it> (permalink)
References	<u9pku-2jJ-19@gated-at.bofh.it>
Organization	Canonical

Show all headers | View raw

On 07/17/2017 12:34 AM, David Binderman wrote:
> Hello there,
> 
> 
> security/apparmor/label.c:1498]: (style) Redundant condition: prev_ns. '!prev_ns || (prev_ns && *prev_ns!=profile->ns)' is equivalent to '!prev_ns || *prev_ns!=profile->ns'
> 
> Source code is
> 
>     if (view != profile->ns &&
>         (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
> 

yep, I will add the fix to the next pull request

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: security/apparmor/label.c:1498]: (style) Redundant condition John Johansen <john.johansen@canonical.com> - 2017-07-31 22:20 +0200

csiph-web